Skip to content

Tests: Improve isolation for randomized rewrite tests - #13193

Closed
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-rewrite-isolation
Closed

Tests: Improve isolation for randomized rewrite tests#13193
sirreal wants to merge 2 commits into
WordPress:trunkfrom
sirreal:agent/test-order-rewrite-isolation

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Flushes rewrite rules after initial taxonomy registration and clears leaked HTTPS server state during rewrite-suite teardown.
  • Keeps the changes confined to PHPUnit tests and fixtures.

Verification

  • 100 randomized rewrite-group runs passed; each completed 1,393 tests and 2,826 assertions.
  • The continuation covered seeds 1789032001 through 1789032050, all with clean exits.
  • Replayed the original failing seed and focused contaminator/consumer cases during diagnosis.
  • PHP syntax checks passed for every changed PHP file.
  • git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

@sirreal sirreal mentioned this pull request Aug 20, 2026
Open
@lancewillett

lancewillett commented Sep 3, 2026

Copy link
Copy Markdown
Member

Updated this branch with a non-rewriting merge of current trunk (1339550).

Validation completed:

  • PHPCS on both changed files
  • Focused rewrite and conditional-query tests: 213 tests, 955 assertions
  • Randomized rewrite group with seeds 13193 and 13195: 1,393 tests, 2,826 assertions each
  • git diff --check

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett
lancewillett marked this pull request as ready for review September 7, 2026 21:51
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

wporg-sync pushed a commit that referenced this pull request Sep 10, 2026
@lancewillett
Tests: Improve isolation of rewrite tests.
ac38246 
Flush rewrite rules after registering the initial taxonomies in conditional-query test setup. Clear the HTTPS server flag during rewrite test teardown so later tests do not inherit it.

Developed in: #13193

Props jonsurrell.
See #65893.


git-svn-id: https://develop.svn.wordpress.org/trunk@63594 602fd350-edb4-49c9-b593-d223f7449a82
@lancewillett

lancewillett commented Sep 10, 2026

Copy link
Copy Markdown
Member

https://core.trac.wordpress.org/changeset/63594

wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Sep 10, 2026
@lancewillett
Tests: Improve isolation of rewrite tests.
480289b 
Flush rewrite rules after registering the initial taxonomies in conditional-query test setup. Clear the HTTPS server flag during rewrite test teardown so later tests do not inherit it.

Developed in: WordPress/wordpress-develop#13193

Props jonsurrell.
See #65893.

Built from https://develop.svn.wordpress.org/trunk@63594


git-svn-id: http://core.svn.wordpress.org/trunk@62770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

WordPress Project Build Tooling
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sirreal @lancewillett